Add Codex Stop-hook plan review#577
Conversation
|
Big one! Give me some time to review but will priortize |
|
Hey! Any luck to be checked soon? |
|
Testing now |
|
Quick question on the Stop hook output format. On approve, the hook outputs |
Short answer: yes for the hook protocol / Why approval is a no-op at the hook layer
So if you mean the Stop hook itself, then yes: approval is just “let the turn finish.” It does not itself switch to Default mode or inject Why that is not the whole story in the TUI/app
Conclusion
|
|
I'm trying one thing with the app server. If it doesn't work, we'll merge this approach. |
|
Releasing this today |
bb9e340 to
6d94ff4
Compare
Summary
Stophook plan review support that extracts the latest plan from rollout transcripts, opens Plannotator for fresh plans, and returns continuation feedback on denialStopflow with server tests and update Codex-facing installation and plan-review docs.playwright-cli/cache so Playwright-driven validation does not dirty the repoTest plan
/bin/bun test apps/hook/server/*.test.ts/bin/bun run --cwd apps/review build/bin/bun run --cwd apps/hook buildPLANNOTATOR_BROWSER=/usr/bin/true ./tests/manual/local/test-codex-plan-review-e2e.sh --keep --skip-build --root-dir /tmp/plannotator-codex-stop-e2e-rerun3with Playwright-driven review, denial, revision, versions, diff, archive, and approval flowScreenshots
Initial plan review
Feedback before denial
Revised plan review
Versions sidebar after denial
Diff view against v1
Archive sidebar